Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added changelog for apm-data upgrade to 1.1 #12944

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Added changelog for apm-data upgrade to 1.1 #12944

merged 2 commits into from
Apr 9, 2024
+2 −0

Conversation

JonasKunz
Copy link
Contributor

Motivation/summary

Checklist

How to test these changes

  • Map new telemetry distro attributes to agent fields for OTel distros apm-data#200:
    • spin up any test application with any OTel-agent
    • Add telemetry.distro.name and telemetry.distro.version as resource-attributes. E.g. use the environment variable OTEL_RESOURCE_ATTRIBUTES=telemetry.distro.name=mydistro,telemetry.distro.version=myversion
    • Verify that the resulting traces (or metrics) have agent.name set to opentelemetry/<language>/mydistro and agent.version is myversion
    • Alternative: Directly send dummy data to the OTLP intake with those resource attributes set
  • Allow host.id via IntakeV2 metadata apm-data#187
    • Use existing dummy data for an IntakeV2 request for generating a transaction
    • Add system.host_id with a value (e.g. foobar) to the metdata-json
    • verify that the resulting transaction now has host.id set to foobar

Related issues

elastic/apm-data#200
elastic/apm-data#187

@JonasKunz JonasKunz requested a review from a team as a code owner April 9, 2024 07:59
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2024

This pull request does not have a backport label. Could you fix it @JonasKunz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 9, 2024
@carsonip carsonip enabled auto-merge (squash) April 9, 2024 08:48
@carsonip carsonip merged commit f758765 into elastic:main Apr 9, 2024
7 checks passed
@JonasKunz JonasKunz deleted the apm-data-bump branch April 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasKunz @carsonip